Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove /title/ and /title/{title}/ #897

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Remove /title/ and /title/{title}/ #897

merged 1 commit into from
Oct 24, 2017

Conversation

d00rman
Copy link
Contributor

@d00rman d00rman commented Oct 23, 2017

No description provided.

@Pchelolo
Copy link
Contributor

Tests need to be updated.

@d00rman
Copy link
Contributor Author

d00rman commented Oct 24, 2017

@Pchelolo removed the now-obsolete tests.

@Pchelolo
Copy link
Contributor

one LGTM waiting for travis.

@Pchelolo
Copy link
Contributor

Ok, the failing test is for PDF and is unrelated. Merging.

@Pchelolo Pchelolo merged commit bb8393e into wikimedia:master Oct 24, 2017
@d00rman d00rman deleted the page-title-removal branch October 25, 2017 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
API hygiene technical debt
Milestone
No milestone
2 participants
@d00rman @Pchelolo