Switch parsed stashing to new storage for new parsed module implementation #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ibcae58ed45d332c0c25794b976482f990dbec535
|
LGTM, but let's not merge it until we have the Cassandra 3 tables in place |
|
Hm, Travis does not concur with my +1, lots of |
d00rman
reviewed
Oct 31, 2017
| } | ||
| } | ||
| return new URI(path); | ||
| return this.getStashBucketURI(rp, format, tid); |
There was a problem hiding this comment.
Hm, the new tables have been created with the -ng suffix, so we need to use it here.
Change-Id: Ie50a2e547343065346feff98a5342df624999d58
Change-Id: I818a212afb17033a87f785a45b3245526982e84d
Pchelolo
force-pushed
the
stash_new_storage
branch
from
e9a983c
to
7d88e11
Compare
|
Fixed node 8 test failure |
Change-Id: I19d1a2d47705f5ee0eb2ea64de59b460618cd81f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @wikimedia/service