Stabilize example config #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I995c3d65b64eb3dd3cecef6ea1e90bf516679ced
d00rman
requested changes
Nov 24, 2017
| @@ -60,10 +60,6 @@ services: | |||
| retry_delay: 250 | |||
| retry_limit: 10 | |||
| show_sql: false | |||
| citoid: | |||
There was a problem hiding this comment.
Why is this being removed?
There was a problem hiding this comment.
Because the example.yaml config don't specify citoid or mathoid modules, so the setting is useless.
CHANGELOG.md
Outdated
|
|
||
| **Breaking changes** | ||
|
|
||
| - `RESTBase` now depends on Cassandra 3.11. In case SQLite backen is used no changes us required. |
CHANGELOG.md
Outdated
| **Breaking changes** | ||
|
|
||
| - `RESTBase` now depends on Cassandra 3.11. In case SQLite backen is used no changes us required. | ||
| - After updating `RESTBase` new keyspaces will be created for everything, so it's effectively starting the storage from scratch. All the content stored in `RESTBase` can be rerendered, so no need to transfer the data, but old keyspaces can be deleted afterwards. New keyspace names have `_ng` suffix. |
There was a problem hiding this comment.
s/keyspace names have _ng/keyspace names have the _ng/
Also, let's limit the line lengths to 80 chars.
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "restbase", | |||
| "version": "0.17.0", | |||
| "version": "0.18.0", | |||
There was a problem hiding this comment.
It's not time to release the new version yet. We need to switch everything over before that can happen.
There was a problem hiding this comment.
I that case maybe let's not add the changelog now but just fix the example config and postpone adding the changelog until we actually make the release?
Change-Id: I9233ca69783214a0b1dfb553edb0616629c56ee8
d00rman
changed the title
d00rman
approved these changes
Nov 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the example configs actually work so that third party or dev installations can use it.
cc @wikimedia/services