Fix duplicate pages in on this day results.

[montehurd]

The events for the following days are examples having dupe pages:

onthisday/events/09/14
"Telecommunications companies MCI Communications and WorldCom complete their $37 billion merger to form MCI WorldCom."

onthisday/events/09/01
"St. Petersburg, Russia, changes its name to Petrograd."

Bug: T175974

[d00rman]

It's actually faster to use Objects to determine whether a value should be filtered out:

return super._hydrateResponse(hyper, req, res).then((response) => {
  Object.keys(response.body).forEach((key) => {
    if (!Array.isArray(response.body[key])) {
      return;
    }
    response.body[key].forEach((elem) => {
      if (!elem || !Array.isArray(elem.pages)) {
        return;
      }
      const titles = {};
      elem.pages = elem.pages.filter((item) => {
        if (titles[item.title]) {
          return false;
        }
        titles[item.title] = true;
        return true;
      });
    });
  });
  return response;
});

[montehurd]

@d00rman
Updated! I kept the declarative naming, but I don't feel super strongly about it if you prefer it more concise.

[montehurd]

@d00rman

Quick question - the REQUEST_TEMPLATE is set to...
{{options.host}}/{{domain}}/v1/feed/onthisday/all/{{mm}}/{{dd}}
...but shouldn't it be something like...
{{options.host}}/{{domain}}/v1/feed/onthisday/{type}/{{mm}}/{{dd}}?

(type being either births, deaths, events, holidays, selected or all)

[d00rman]

@montehurd Nope, because we need all for storage purposes. When another type is requested, it's filtered out here so the client gets only what they asked for.