updated the versions of numpy,scipy & scikit-learn #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@halfak I made my patch, hoping to recieve your kind reviews on it :) |
halfak
reviewed
Jul 3, 2019
requirements.txt
Outdated
| @@ -12,12 +12,12 @@ mwtypes >= 0.2.0, < 0.3.999 | |||
| mwparserfromhell >= 0.5.1, < 0.5.999 | |||
| mysqltsv >= 0.0.7, < 0.0.999 | |||
| nltk >= 3.0.0, < 3.0.999 | |||
| numpy >= 1.14.0, < 1.14.999 | |||
| numpy >= 1.16.2, < 2.0.999 | |||
There was a problem hiding this comment.
I think we'll want to stay within minor version for these ranges. E.g. numpy >= 1.16.2, < 1.6.999. See https://semver.org/ for the meaning of these numbers.
There was a problem hiding this comment.
cool. Will apply the review made :)
|
Thanks a lot for your patience and time.
That makes my 3rd patch to Wikimedia :)
Best
Kaushik.
…On Wed, Jul 3, 2019, 7:34 PM Aaron Halfaker ***@***.***> wrote:
Merged #442 <#442> into
master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#442?email_source=notifications&email_token=AKEHCGHNHQV2RLRDQVII6KTP5SWYTA5CNFSM4H5DJAJKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSJ6YQDY#event-2457700367>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKEHCGAOZ77UXTQGDNSR4K3P5SWYTANCNFSM4H5DJAJA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had updated according to the latest versions of those specified libraries, according to SemVer.
Requesting to get it review my commit.