Have gc-stats and heapdump as optionalDeps; release v2.6.17 #208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having
gc-stats
andheapdump
being added to the build process post-facto is problematic for services being deployed to Kubernetes, as they won't be using the build script that comes withservice-runner
. Therefore, make them optional dependencies. This will allow us to have them installed in production afternpm install
, all the while not breaking the installation process for systems that do not support these modules.Bug: T205911