Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor shutdown sequence; rel v2.7.3 #220

Merged
merged 1 commit into from Aug 1, 2019

Conversation

Pchelolo
Copy link
Contributor

  1. Update dependencies.
  2. Don't attempt to send heartbeats if we're shutting down.
  3. Refactor shutdown sequence. Before we were killing the worker when master detected the worker was disconnected. That's actually no good, cause master can emit the disconnect event before the worker does, so this doesn't leave the worker required time to gracefully kill itself after all the cleanup is done. Now we only SIGKILL the worker if it's stuck in its shutdown sequence for some time, and normally relying on the worker to correctly kill itself.

Bug: https://phabricator.wikimedia.org/T158265

@d00rman d00rman changed the title Refactor shutdown sequence. Refactor shutdown sequence; rel v2.7.3 Aug 1, 2019
@d00rman d00rman merged commit 0894ee3 into wikimedia:master Aug 1, 2019
@d00rman
Copy link
Contributor

d00rman commented Aug 1, 2019

Published as v2.7.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants