Logger improvements #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logger uses the _levelMatcher private property to determine if a log entry should be logged or not. However, the threshold is set based on conf.level, without taking into account individual stream levels. That causes log entries for levels lower than the global level not to be logged in the individual log streams. This commit performs the check to find the minimum log level to use correctly based on individual stream settings. Additionally, it explicitly appends the level property to streams lacking it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logger uses the
_levelMatcherprivate property to determine if a log entry should be logged or not. However, the threshold is set based onconf.level, without taking into account individual stream levels. That causes log entries for levels lower than the global level not to be logged in the individual log streams.This PR performs the check to find the minimum log level to use correctly based on individual stream settings. Additionally, it explicitly appends the
levelproperty to streams lacking it. The stream conversion has been slightly improved to ease the addition of new stream converters, and converters forstdoutandstderrhave been added.Bug: T105500