Use swagger-ui-dist instead of swagger-ui #115
Conversation
Based on hyperswitch implementation. See wikimedia/hyperswitch@a040a59 Bug: T218217
|
Actually, let's not do that just yet, let's get rid of the optional params first too.
|
We should do it as a part of the same PR actually.. |
Or that, yes, even better. @mateusbs17 could you adjust the routes in |
Ok. One question, should we remove specific code that checks for swagger 2.0 spec versions and keep only openapi 3? |
|
Hm I see in MCS patch you are switching to openApi 3 right away. I think given that this is a template, let's be bold and completely switch to openapi 3 here too? What do you think @d00rman ? |
+1, let's do it. Apart from the optional path param, that we need to get rid of anyway, there's nothing that ties us to v2 in the spec template. |
1) Removing 'node' from travis.yml, support node 10 instead of node 8 2) Support only openapi 3 spec 3) Update spec.example.yaml to be openapi 3 compliant 4) Bump minor version
| @@ -256,7 +256,7 @@ describe('Swagger spec', function() { | |||
| defParams = spec['x-default-params']; | |||
| } | |||
| // check the high-level attributes | |||
| ['info', 'swagger', 'paths'].forEach((prop) => { | |||
| ['info', 'openapi', 'paths'].forEach((prop) => { | |||
There was a problem hiding this comment.
Let's use openapi-schema-validator in this test just like RESTBase does.
|
I'm gonna merge this and do a couple of followups |
1) Change tests and app configuration for openapi 3.0 compliance 2) PR to upstream service-template-node, see wikimedia/service-template-node#115 3) Use response and examples components to avoid code duplication 4) Change how spec.js tests x-amples on the new specification 5) Rebase + update specs for talk, media-list, and mobile-section-lead 6) Allow components to be added in the endpoint file and do a 2 level depth merge only in the components key Bug: T218220 Change-Id: Ibea93c3b790f2624f63380a8bcde95221f438ced
Based on hyperswitch implementation.
Bug: T218217