Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder stylelint rules #38

Merged
merged 3 commits into from Oct 11, 2016
Merged

Reorder stylelint rules #38

merged 3 commits into from Oct 11, 2016

Conversation

Volker-E
Copy link
Contributor

@Volker-E Volker-E commented Oct 6, 2016 •
edited by Krinkle

Reordering stylelint rules for better scan-ability in alphabetical order with exceptions for special
Wikimedia Foundation whitespace treatment.

Issue: #5

@Volker-E
Reorder stylelint rules
f3abb6e 
Reordering stylelint rules for better scan-ability 
in alphabetical order with exceptions for special 
Wikimedia Foundation whitespace treatment and
property value blacklist.

Fixes #5
@Volker-E
Copy link
Contributor Author

Volker-E commented Oct 6, 2016

Thinking through work on PR yesterday, I struggled with declaration-property-value-blacklist position.
Reconsidering it, it makes more sense just to have one exception to alphabetical order and not one at the beginning and one at the end, putting declaration-property-value-blacklist in the order as well.

@Volker-E
Copy link
Contributor Author

Volker-E commented Oct 6, 2016

@jdforrester Amended PR accordingly.

@jdforrester
Copy link
Member

Yeah, that's fine. @Krinkle, @edg2s — do you have thoughts or should I just merge?

@edg2s edg2s merged commit 1e9858e into master Oct 11, 2016
@Krinkle Krinkle deleted the stylelint-rule-order-#5 branch October 12, 2016 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Krinkle Krinkle Krinkle approved these changes

@jdforrester jdforrester jdforrester approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Volker-E @jdforrester @Krinkle @edg2s