Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use replacement placeholders in the render command #767

Merged
merged 1 commit into from
May 23, 2024
Merged

Use replacement placeholders in the render command #767

merged 1 commit into from
May 23, 2024

Conversation

samwilson
Copy link
Member

  • Switch to using process command placeholders rather than environment variables in constructing the rsvg-convert command.
  • Only pass required placeholders.
  • Use Symfony's AcceptHeader class to reformat the lang value.

Bug: T365644

@samwilson
Use replacement placeholders in the render command
4a3e634 
* Switch to using process command placeholders rather than
  environment variables in constructing the rsvg-convert command.
* Only pass required placeholders.
* Use Symfony's AcceptHeader class to reformat the lang value.

Bug: T365644
@theresnotime theresnotime merged commit cc0aef7 into main May 23, 2024
2 checks passed
@theresnotime theresnotime deleted the render-args branch May 23, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theresnotime theresnotime theresnotime approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@samwilson @theresnotime