Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: fix debugging messages #54

Merged
merged 3 commits into from
Mar 29, 2023

Conversation

nbarnabee
Copy link
Collaborator

This addresses T333016

Console logging the entire error was spamming the console with
massive amounts of useless information.

My linter also inserted some semi-colons, thereby fixing a
formatting inconsistency.
@nbarnabee nbarnabee changed the title Bugfix: error messages not behaving correctly. Bugfix: error messages not behaving as expected. Mar 24, 2023
This line was producing the "This error: false" messages.
Makes them slightly more informative.
@nbarnabee nbarnabee marked this pull request as ready for review March 25, 2023 12:25
@nbarnabee
Copy link
Collaborator Author

I've dealt with the visual problem and cleaned up the console.log messages. The real problem exists on the backend (see T333016 and wikimedia/toolhunt#58

@nbarnabee nbarnabee changed the title Bugfix: error messages not behaving as expected. Bugfix: fix debugging messages Mar 26, 2023
@Damilare1 Damilare1 merged commit d7de50a into wikimedia:main Mar 29, 2023
@nbarnabee nbarnabee deleted the bugfix-error-msgs branch March 30, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants