Bugfix: Format data values for multi-choice fields #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest changes to main appear to have broken this. I'll try to figure out what's gone wrong. |
This addresses https://phabricator.wikimedia.org/T331262 As I wasn't having any luck creating a custom schema that would correctly handle both strings and lists, I opted to accept a string and convert it into a list. Unfortunately, Flask did not do a good job of converting the resulting data to a valid JSON, so I had to do it manually.
nbarnabee
force-pushed
the
convert-data-to-list
branch
from
0cbf762
to
f6eb95b
Compare
blancadesal
approved these changes
Mar 7, 2023
api/utils.py
Outdated
| @@ -8,9 +9,13 @@ | |||
|
|
|||
|
|
|||
| def build_request(form_data): | |||
There was a problem hiding this comment.
nit: I'd rename this function to build_put_request for more clarity
There was a problem hiding this comment.
I have sullied this PR with an unrelated change. I hope you're happy!! 🤣
This change is completely unrelated to this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses https://phabricator.wikimedia.org/T331262
As I wasn't having any luck creating a custom schema that would correctly handle both strings and lists, I opted to accept a string and convert it into a list.
Unfortunately, Flask did not do a good job of converting the resulting data to a valid JSON, so I had to do it manually.