Modify auth flow for transkribus to include refresh token #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samwilson
reviewed
Feb 21, 2023
samwilson
reviewed
Feb 22, 2023
samwilson
reviewed
Feb 22, 2023
Added static methods for making accesstoken and refreshtoken requests
Parthiv-M
commented
Feb 23, 2023
Removed accessToken and refreshToken arguments from TranskribusClient constructor Added env variables to phpunit.xml.dist
… and removed reduntant auth code
samwilson
reviewed
Feb 24, 2023
Replaced magic number with a constant in TranskribusClient and removed TranskribusClient services from services config
kolakachi
approved these changes
Feb 24, 2023
samwilson
reviewed
Feb 27, 2023
src/Engine/TranskribusEngine.php
Outdated
| Intuition $intuition, | ||
| string $projectDir, | ||
| HttpClientInterface $httpClient | ||
| ) { | ||
| parent::__construct($intuition, $projectDir, $httpClient); | ||
|
|
||
| $this->transkribusClient = $transkribusClient; | ||
| $this->transkribusClient->setTokens($accessToken, $refreshToken); |
There was a problem hiding this comment.
The tokens are only injected here in order to be passed through to the client — would it be better to inject them into the client instead?
Moved token injection from TranskribusEngine to TranskribusClient Updated OcrControllerTest and services.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the authentication flow of the Transkribus engine to use refresh tokens in addition to access tokens
Bug: T330052