Add 3 items to COPY_ATTRIBUTES which are used by iOS. #112
Conversation
| const COPY_ATTRIBUTES = ['class', 'style', 'src', 'srcset', 'width', 'height', 'alt'] | ||
| // The 3 data-* items are used by iOS. | ||
| const COPY_ATTRIBUTES = ['class', 'style', 'src', 'srcset', 'width', 'height', 'alt', | ||
| 'data-file-width', 'data-file-height', 'data-image-gallery' |
There was a problem hiding this comment.
This seems like a pretty harmless change. It's entirely up to your discretion but you may want to update tests for these new attributes. We currently validate all others and don't have to worry about breaking things so much when a change is made.
Just an aside and not a request for revision: on line 77, these attributes will be copied to data-data-* which is a bit clumsy. On the other hand, they can be handled generically without any other changes which is great.
There was a problem hiding this comment.
Ya I had to account for the data-data prefix when implementing tap handling wikimedia/wikipedia-ios@8d50837 on the placeholders (ie if a user taps the placeholder span it was nice to have that still try to show the native gallery for that placeholder's image). Agreed it's a bit clumsy, but figured we could circle back later if we refactor in future.
There was a problem hiding this comment.
@niedzielski Tests added :)
|
@dbrant gave thumbs-up on irc. merge time! |
Background.
https://phabricator.wikimedia.org/T175323