This repository has been archived by the owner on Sep 2, 2020. It is now read-only.
Allow client to specify if and what edit buttons should be shown #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds new function Page.setEditButtons(isEditable, isProtected).
joewalsh
approved these changes
Jul 26, 2019
wmfgerrit
pushed a commit
to wikimedia/mediawiki-services-mobileapps
that referenced
this pull request
Jul 29, 2019
to avoid FoUC when loading an uneditable or protected page, or a page edit preview, or for clients that have not implemented editing. Depends on wikimedia/wikimedia-page-library#232 Bug: T228437 Change-Id: I995de76d488b210bfbe4b6fb9c1594a8ebbffef5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new function Page.setEditButtons(isEditable, isProtected).
Bug: T228437