This repository has been archived by the owner on Sep 2, 2020. It is now read-only.
Add 'notheme' #255
Merged
Add 'notheme' #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesocialdev
approved these changes
Oct 21, 2019
|
@joewalsh Does it still need to be confirmed as a viable solution? Waiting on that to merge this PR and https://gerrit.wikimedia.org/r/c/mediawiki/services/mobileapps/+/544854 |
|
@thesocialdev It still needs to be confirmed that this is a viable solution and there's not a better option. Adding the |
wmfgerrit
pushed a commit
to wikimedia/mediawiki-services-mobileapps
that referenced
this pull request
Oct 21, 2019
It's by far the most expensive mobile-html transform and isn't a sustaianble way to exclude items from theme application. I'm proposing a CSS class - .notheme - that editors can add to templates to exclude specfic items. Corresponding pagelib pr is here: wikimedia/wikimedia-page-library#255 but this can be merged indepenedently of that. Bug: T229286 Change-Id: I30001bd65c5264aea3551827d63697557d306fe1
thesocialdev
changed the title
This reverts commit 556163f.
joewalsh
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T229286
classifyElementsis by far the slowest part of preparingmobile-html. It's not sustainable to keep adding exclusions to the list of specific filenames and query selectors.I'm proposing we add
nothemeand request editors add it to the appropriate templates ahead of the launch ofmobile-html. This will allow themobile-htmlendpoint to stop callingclassifyElements. There is some precedent for this withnomobile(now obviated by TemplateStyles) but will need to confirm that this is a viable option.