Fix media list api #192
Merged
Fix media list api #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, I have tested on banana device as well as browser and images seem to be working properly now. @jpita for context: this PR represents a quick fix as an immediate response to T248553, just to get images working again and remove any serious blockers. Coming next, Stephane said he'd create follow up Phabricator tickets to address any other consequential codebase adjustments |
medied
approved these changes
Mar 26, 2020
|
What is the difference in behaviour from the original feature? |
|
@jpita we restored the ability to read an article and browse the images but we don't have the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a quick fix for media -> media-list