T248611 Restore "about" feature in article gallery view #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Article
|
|
Reviewing this PR was useful for me to further understand how to use |
medied
reviewed
Apr 1, 2020
medied
previously approved these changes
Apr 1, 2020
|
this pr requires more update on the api, see the comment in ticket, in short summary, the image is not always from Commons. |
|
Ok, change is done and ready to be reviewed again, thanks for the input! |
medied
reviewed
Apr 2, 2020
| title: item.title, | ||
| canonicalizedTitle: | ||
| item.title && canonicalizeTitle(item.title.split(':')[1]) | ||
| item.title && canonicalizeTitle(item.title.split(':')[1]), | ||
| fromCommon: source.indexOf('/commons') !== -1 |
There was a problem hiding this comment.
Nice, good idea to declare source at the top
medied
approved these changes
Apr 2, 2020
|
Tested latest change on banana device using Brasilien article and it worked as expected, btw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator Link: https://phabricator.wikimedia.org/T248611
Problem Statement
pcs
mediaapi is being removed recently, switch to mw apiSolution
fetch the api only when user press About center key
Note
|