New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App manifest: use only supported locales #200
Conversation
'or-IN', | ||
'pa-IN', | ||
'sa-IN', | ||
'sd-IN', // RTL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RTL stands for right to left, correct?
This seems to be working well. Here's the test that I did with the banana phone:
The above makes sense to me and my understanding is that's the behavior we are looking for. At this point I was able to switch the app language through the app normally, and set it back to Portuguese at the end. After that:
This also makes sense to me, I'm assuming that's expected behavior as well. |
The encoding is messed up for you. What does it look like when you open |
it looks good to me in fr.json file "app-title": "Wikipédia",
"app-subtitle": "L’encyclopédie libre",
"app-description": "Avec l’application libre Wikipédia, cherchez et explorez des informations du monde entier en plus de 300 langues.", |
Ooo.. then forget about Windows env. |
I can't find the locale in the supported locales, we added them to language file before for |
We only want the languages that are supported by KaiOS or Jio. This is to display the app info in the store in the same language as the phone. If there's no way to set your phone to Bodo, then there is no need for this translation in the manifest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Phabricator Link: https://phabricator.wikimedia.org/T248675
Problem Statement
KaiOS has a limited set of supported language. For displaying basic app information in the store, it needs the exact language codes it knows about. For instance, it supports both
fr-CA
andfr-FR
and needs to see those codes exactly in the manifest. It won't pick up translations simply forfr
.Solution
Generate the manifest locales from the lists of supported locales for KaiOS and Jio and map to the i18n files as needed.