T263598 keyboard shortcuts on gallery #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to work well |
hueitan
changed the title
hueitan
commented
May 11, 2021
Comment on lines
+354
to
+369
| case 'ArrowRight': | ||
| case 'Right': | ||
| if ( dir === 'ltr' ) { | ||
| renderNext() | ||
| } else { | ||
| renderPrevious() | ||
| } | ||
| break | ||
| case 'ArrowLeft': | ||
| case 'Left': | ||
| if ( dir === 'ltr' ) { | ||
| renderPrevious() | ||
| } else { | ||
| renderNext() | ||
| } | ||
| break |
There was a problem hiding this comment.
This is so native, any idea to improve?
stephanebisson
approved these changes
May 12, 2021
medied
reviewed
May 12, 2021
| @@ -0,0 +1,16 @@ | |||
| let eventListenerStack = [] | |||
There was a problem hiding this comment.
Should all gallery event listeners be included in this new array? The ones in applyGestureEvent for example? Mainly asking because that would overlap the image zoom feature I'm working on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator Ticket : https://phabricator.wikimedia.org/T263598