T262373: add gallery focus mode #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hueitan
approved these changes
Nov 6, 2020
src/gallery/slider.js
Outdated
| @@ -260,6 +315,30 @@ const clientWidth = window.innerWidth, | |||
| } ) | |||
| }, | |||
|
|
|||
| toggleFocusMode = () => { | |||
| const toggleElements = [ | |||
There was a problem hiding this comment.
Did you consider only flipping a class here and apply the proper show/hide in CSS?
There was a problem hiding this comment.
Seems like a good idea, let me look into that
There was a problem hiding this comment.
I think the class should be put higher up on a single element. Which elements should be shown or hidden can be handled in CSS.
There was a problem hiding this comment.
Ah I think I see what you meant with your first comment, check out 3248fae. I like this much better, fully takes advantage of the cascading property of CSS to simplify and:
- get rid of the nested looping,
- get rid of
focusModestate variable - make it more readable and maintainable
Thanks for the great feedback!
|
I have merged the latest master to this branch, easier for us to review the changes code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T262373
The gallery focus mode allows users to hide all other information in the gallery with a single tap to only display the image itself.
Note this PR builds on top of #85, hence the commit list showing all commits. The only commit relevant to focus mode at this point is 26d2743.
Let's aim to merge #85 first.