Update styling for controllers in mobile view #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hueitan
reviewed
Sep 18, 2023
hueitan
reviewed
Sep 18, 2023
hueitan
reviewed
Sep 18, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T340660
This is mainly a styling change to update the mobile view of edit controllers (change, remove) for the preview of the Wikipedia Preview. In order to ensure the new dots menu is correctly positioned regardless of preview height, I opted for inserting it directly in the preview header (trying to position it on the fly was messy and not getting me anywhere). This is what the controllers look like on mobile now (1), including RTL support (2), and the desktop view is left unchanged (3).
Also note I'm adding the eslint exception because according to https://react.dev/reference/react/useState#updating-state-based-on-the-previous-state, we need to use an updater function for
toggleControllersMenuto work correctly.