Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create option to disable credits in export form #342

Merged
merged 1 commit into from Mar 17, 2021
Merged

Conversation

cimurah
Copy link
Contributor

@cimurah cimurah commented Mar 12, 2021

Add option that will exclude/include credits in exported books.

Bug: T274959

Copy link
Member

@samwilson samwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, works well.

i18n/en.json Outdated Show resolved Hide resolved
src/Generator/EpubGenerator.php Outdated Show resolved Hide resolved
@cimurah cimurah requested a review from samwilson March 16, 2021 00:15
@cimurah cimurah added Ready for review and removed WIP Work in progress labels Mar 16, 2021
Copy link
Member

@samwilson samwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably not that common to have the interface language differ from the book language, but it's not hard to support so we might as well.

src/Generator/EpubGenerator.php Show resolved Hide resolved
src/Generator/EpubGenerator.php Show resolved Hide resolved
Add option that will exclude/include credits in exported books.

Bug: T274959
@samwilson samwilson merged commit fb48f43 into main Mar 17, 2021
@samwilson samwilson deleted the add-credits-option branch March 17, 2021 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants