Reduce width of form and fix label font sizes #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MusikAnimal
requested changes
Mar 31, 2021
There was a problem hiding this comment.
Seems to meet the acceptance criteria! I'm assuming @nayoub wanted the content to be centered (this is unclear from the mockup)?
The only issue I see is this breaks the mobile responsiveness, which I think can be fixed by simply using max-width instead of width.
public/styles.css
Outdated
| /* 1170 is bootstrap's widest breakpoint, and the 85 and 20 are for the logo. */ | ||
| width: calc( 1170px + ( ( 85px + 20px ) * 2 ) ); | ||
| /* 585 is the container width set above, and the 85 and 20 are for the logo. */ | ||
| width: calc( 585px + ( ( 85px + 20px ) * 2 ) ); |
There was a problem hiding this comment.
This and above should maybe be max-width to retain the responsive design. Otherwise content exceeds the viewport on mobile devices.
|
Yes exactly, centered looks great! Thanks @MusikAnimal & @samwilson! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: https://phabricator.wikimedia.org/T277820