Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mw:Extension link elements #361

Merged
merged 1 commit into from Apr 7, 2021
Merged

Remove mw:Extension link elements #361

merged 1 commit into from Apr 7, 2021

Conversation

samwilson
Copy link
Member

These are not valid in EPUBs.

Bug: https://phabricator.wikimedia.org/T272819

Tpt
Tpt approved these changes Apr 7, 2021
View reviewed changes
Copy link
Collaborator

@Tpt Tpt left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about removing all meta and link? I am not sure there is any proper usecase for them.

@samwilson
Copy link
Member Author

Hmm that's a good point. These are the only ones that epubcheck is complaining about (although, maybe this is all of them, I've not really looked deeply yet...)

@samwilson samwilson merged commit 26a1e75 into main Apr 7, 2021
@samwilson samwilson deleted the rm-link branch April 7, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tpt Tpt Tpt approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@samwilson @Tpt