This repository has been archived by the owner on Apr 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
[component][typeahead-suggestion] Add network client for typeahead-search component #72
Merged
Commits on Jul 31, 2020
-
In most browsers we can use window.fetch. In others, like IE 11, this is not available. To keep this simple for now reject the promise if native fetch is not available. Added jest-fetch-mock for testing the "fetch is available" branch.
Configuration menu - View commit details
-
Copy full SHA for 610e2cd - Browse repository at this point
Copy the full SHA 610e2cdView commit details -
A convenience method to serialize a JS object into a query string, so it can be appended to the URL (after '?').
Configuration menu - View commit details
-
Copy full SHA for 0a660a2 - Browse repository at this point
Copy the full SHA 0a660a2View commit details -
This network client provides a fetchByTitle() function, to be used for typeahead search suggestions. Not providing accept-language header at this time since it does not seem to make a difference.
Configuration menu - View commit details
-
Copy full SHA for ff9b4a8 - Browse repository at this point
Copy the full SHA ff9b4a8View commit details -
Allow API tests to run against live servers
By default the requests are mocked, so no network is used. If the environment variable TEST_LIVE_REQUESTS is set to a truthy value, the mocks are disabled and requests are made against a live server.
Configuration menu - View commit details
-
Copy full SHA for 836648f - Browse repository at this point
Copy the full SHA 836648fView commit details
Commits on Aug 3, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 4fe737c - Browse repository at this point
Copy the full SHA 4fe737cView commit details -
Move jestFetchMock.enableFetchMocks() into beforeAll
Also undo in afterAll(). Plus a formatting fix.
Configuration menu - View commit details
-
Copy full SHA for 81a0602 - Browse repository at this point
Copy the full SHA 81a0602View commit details -
Configuration menu - View commit details
-
Copy full SHA for 52ccd37 - Browse repository at this point
Copy the full SHA 52ccd37View commit details -
Configuration menu - View commit details
-
Copy full SHA for a402cb3 - Browse repository at this point
Copy the full SHA a402cb3View commit details
Commits on Aug 4, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 9ac0a9f - Browse repository at this point
Copy the full SHA 9ac0a9fView commit details -
Explicitly type RestResponse in test
Doing that I noticed that the null values need to be called out in the interface.
Configuration menu - View commit details
-
Copy full SHA for 756882f - Browse repository at this point
Copy the full SHA 756882fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 841da9f - Browse repository at this point
Copy the full SHA 841da9fView commit details -
Add searchText to the search response
so it can be used by the UI for highlighting the search text.
Configuration menu - View commit details
-
Copy full SHA for ae5f10c - Browse repository at this point
Copy the full SHA ae5f10cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 21c992c - Browse repository at this point
Copy the full SHA 21c992cView commit details
Commits on Aug 5, 2020
-
Titles don't start or end with spaces. So, remove them, at least for title search.
Configuration menu - View commit details
-
Copy full SHA for 97fc0b8 - Browse repository at this point
Copy the full SHA 97fc0b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 304de07 - Browse repository at this point
Copy the full SHA 304de07View commit details -
Handle null thumbnail width/height
The REST API documentation says it could return null for width or height. Make the value undefined in this case.
Configuration menu - View commit details
-
Copy full SHA for 0a24a02 - Browse repository at this point
Copy the full SHA 0a24a02View commit details
Commits on Aug 6, 2020
-
Reuse input object for test verification
Clarify that the input object changes in one place where the thumbnail is null.
Configuration menu - View commit details
-
Copy full SHA for 6ff044a - Browse repository at this point
Copy the full SHA 6ff044aView commit details
Commits on Aug 12, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 124b10b - Browse repository at this point
Copy the full SHA 124b10bView commit details -
Configuration menu - View commit details
-
Copy full SHA for fcb845d - Browse repository at this point
Copy the full SHA fcb845dView commit details
Commits on Aug 13, 2020
-
Configuration menu - View commit details
-
Copy full SHA for a190a23 - Browse repository at this point
Copy the full SHA a190a23View commit details -
Configuration menu - View commit details
-
Copy full SHA for 70b88b9 - Browse repository at this point
Copy the full SHA 70b88b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c9faef - Browse repository at this point
Copy the full SHA 1c9faefView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a25ff8 - Browse repository at this point
Copy the full SHA 4a25ff8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.