Add a Dockerfile for deployments #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethn
approved these changes
Apr 22, 2024
| RUN cp -R config/sample/* config && \ | ||
| rm -R config/sample | ||
|
|
||
| RUN bundle config without test cucumber cypress development profile |
There was a problem hiding this comment.
alternatively you could copy a .bundle/config file. Not a dramatic difference, but maybe some day we'll want to tweak other bundle configurations...
| @@ -96,7 +97,6 @@ gem "timecop", group: %i[test cucumber] # date/time manipulation in tests | |||
| group :test, :development do | |||
| # gem "debase" | |||
| gem "decko-spring", path: "./vendor/decko/support" | |||
| gem "puma", "~>5.6" # local webserver (6.x broke semaphore ) | |||
There was a problem hiding this comment.
Is the notion that this is an interim solution and that we'll move to something more powerful before going live? Puma is a pretty lightweight webserver. I'd have to look a little more closely at our apache configurations to make specific arguments about what it can and can't do.
But maybe the idea is that since each container has its own webserver, ligthweight is best?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.