-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pagination for listing books #271
Add pagination for listing books #271
Conversation
@AmrAdelKhalil this is great, and works super well! It seems though that you bundled solutions to two other unrelated problems here:
Would you mind updating this PR to only include code and commits relevant to pagination? I encourage you to open new PRs for each of those other problems above. This way we have a clean and clear development history that someone new in the future would be able to understand and contribute to. Thank you so much! Freddie |
Oh! PS: I've merged in all your other wonderful improvements! Thanks a million! 🎂 |
65d0ec0
to
f153832
Compare
…ecent_with_content receiving page number, creating new route /books/show_more, updating Profile.es6.jsx to work with pagination
f153832
to
ddd34ab
Compare
@FredericoAndrade Hey, I |
@AmrAdelKhalil amazing work here! I've made some minor tweaks and merged it to master. Would you like to try and make the lazy load into its own component so we can use it in other lists? it would be really cool if we could just pass it some content, and have it paginate. I'm thinking specifically about the 'my books' and 'favorite books' section in the profile page, the book list in the logged out landing page, and perhaps even phrases inside long phrasebooks. What do you think? |
@FredericoAndrade, Hey |
No description provided.