Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination for listing books #271

Conversation

AmrAdelKhalil
Copy link
Contributor

No description provided.

@FredericoAndrade
Copy link
Contributor

@AmrAdelKhalil this is great, and works super well! It seems though that you bundled solutions to two other unrelated problems here:

  1. Removing unused tables on the schema
  2. Fixing server errors on book saves

Would you mind updating this PR to only include code and commits relevant to pagination? I encourage you to open new PRs for each of those other problems above. This way we have a clean and clear development history that someone new in the future would be able to understand and contribute to.

Thank you so much!

Freddie

@FredericoAndrade
Copy link
Contributor

FredericoAndrade commented Dec 25, 2017

Oh! PS: I've merged in all your other wonderful improvements! Thanks a million! 🎂

…ecent_with_content receiving page number, creating new route /books/show_more, updating Profile.es6.jsx to work with pagination
@AmrAdelKhalil
Copy link
Contributor Author

@FredericoAndrade Hey, I rebased this branch too, Could you check if it gonna make any history problems.
I'm going to open new pull requests for the first point, second point (server-side) has already an opened pull request.

@FredericoAndrade FredericoAndrade merged commit ec10e3e into wikitongues:master Jan 3, 2018
@FredericoAndrade
Copy link
Contributor

@AmrAdelKhalil amazing work here! I've made some minor tweaks and merged it to master.

Would you like to try and make the lazy load into its own component so we can use it in other lists? it would be really cool if we could just pass it some content, and have it paginate. I'm thinking specifically about the 'my books' and 'favorite books' section in the profile page, the book list in the logged out landing page, and perhaps even phrases inside long phrasebooks. What do you think?

@AmrAdelKhalil
Copy link
Contributor Author

@FredericoAndrade, Hey
I think it gonna be better of course, I'm gonna work on it this weekend but first Here are my thoughts of them:
1- for favorite books and my books gonna work with (right and left) arrows + numbers ( page_number)
2- Landing page ( it will happen automatically like the list of books in the profile page)
3- phrases ( I would prefer to make a "load more" hyperlink which requests more phrases from the back-end)
What do think about these scenarios?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants