Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generated cargo_dependencies.bzl requires buildifier formatting #11

Closed
aignas opened this issue Feb 13, 2021 · 1 comment
Closed

generated cargo_dependencies.bzl requires buildifier formatting #11

aignas opened this issue Feb 13, 2021 · 1 comment

Comments

@aignas
Copy link

aignas commented Feb 13, 2021

A low hanging fruit, but wanted to file this as I discovered it during experimenting to move my personal monorepo from raze to blackjack.

Affected lines example: https://github.com/aignas/c/pull/16/commits/4088aa9ffc859a6e6eeb2f0914a35dc211655df2
@aignas aignas changed the title generated cargo_dependencies.bzl file that requires buildifier formatting. generated cargo_dependencies.bzl requires buildifier formatting Feb 13, 2021
@aignas
Copy link
Author

aignas commented Feb 16, 2021

I thought I would simply fix it, but adding a regression test is slightly more complex.

I imagine it would be good to use a similar approach to bazelbuild/rules_rust#570.

@aignas aignas closed this as not planned Won't fix, can't repro, duplicate, stale Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aignas