Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run buildifier fix across the workspace #570

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

hlopko
Copy link
Member

@hlopko hlopko commented Feb 2, 2021

No description provided.

Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a check to the presubmit to enforce this for the future?

I'm on board with one-off disruptive formatting changes, but only if there's only one of them, which is less likely to be the case without a presubmit :)

@hlopko
Copy link
Member Author

hlopko commented Feb 2, 2021

Oh good point, I thought we already get all the warnings. My bad. Done.

This is how we stand against the full wrath of the buildifier before this PR: https://buildkite.com/bazel/rules-rust-rustlang/builds/2054

Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants