Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the get!(d::LMDBDict, key, default), get(f::Function, d::LMDBDict, key), and get!(f::Function, d::LMDBDict, key) methods #32

Merged
merged 1 commit into from Sep 2, 2022
Merged

Add the get!(d::LMDBDict, key, default), get(f::Function, d::LMDBDict, key), and get!(f::Function, d::LMDBDict, key) methods #32

merged 1 commit into from Sep 2, 2022

Conversation

DilumAluthge
Copy link
Contributor

No description provided.

@DilumAluthge
Copy link
Contributor Author

@wildart Would you mind approving the workflows to run?

meggart
meggart approved these changes Aug 30, 2022
View reviewed changes
src/dicts.jl Outdated Show resolved Hide resolved
src/dicts.jl Outdated Show resolved Hide resolved
@meggart
Copy link
Collaborator

meggart commented Sep 1, 2022

Tests are still failing, probably the branch needs a rebase?

@coveralls
Copy link

coveralls commented Sep 1, 2022 •
edited

Coverage Status

Coverage increased (+3.03%) to 70.641% when pulling fd893b2 on DilumAluthge:dpa/more-get-methods into 94f4542 on wildart:master.

@DilumAluthge DilumAluthge marked this pull request as draft September 1, 2022 16:35
@DilumAluthge
Add the get!(d::LMDBDict, key, default), `get(f::Function, d::LMDBD…
fd893b2 
…ict, key)`, and `get!(f::Function, d::LMDBDict, key)` methods
@DilumAluthge DilumAluthge marked this pull request as ready for review September 1, 2022 16:52
@DilumAluthge
Copy link
Contributor Author

@meggart I've added some tests, and CI is green now.

@meggart meggart merged commit 0d129c2 into wildart:master Sep 2, 2022
@meggart
Copy link
Collaborator

meggart commented Sep 2, 2022

Thanks a lot!

@DilumAluthge DilumAluthge deleted the dpa/more-get-methods branch September 2, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meggart meggart meggart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DilumAluthge @meggart @coveralls