Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private Message Box Needs Work #35

Closed
WildcardSearch opened this issue Feb 3, 2013 · 4 comments
Closed

Private Message Box Needs Work #35

WildcardSearch opened this issue Feb 3, 2013 · 4 comments
Assignees
@WildcardSearch
Labels
bug enhancement fixed
Milestone
1.4

Comments

@WildcardSearch
Copy link
Owner

The Private Messages default module is weak and also wastes a lot of execution producing content that is already available through the $mybb object.

Need to remove unnecessary code, eliminating those queries as well.

Also, it would be nice to add a little more functionality to the Search Box as well.
@ghost ghost assigned WildcardSearch Feb 3, 2013
WildcardSearch pushed a commit that referenced this issue Feb 3, 2013
Beta Update #4
b648407 
Issue #35 fixed by reworking Search box templates to use `$mybb` object (saving unnecessary queries) and added options to the search box.

Issue #36 fixed by checking that an add-on module is installed before upgrading (casued uninstalled modules to instantly be re-installed on load (any load of `Sidebox_handler` object)

Issue #29 addressed again to further simplify moduls as much as possible for the developer and end-user while maintaining performace and functionality.

Thanks to @avril-gh for patience and for speaking up!
@WildcardSearch
Copy link
Owner Author

Fixed.

@avril-gh
Copy link
Contributor

avril-gh commented Feb 4, 2013

The Private Messages default module is weak and also wastes a lot of execution producing content that is already available through the $mybb object.

Even tho this is not this nor other addons fault, because the true cause come from core design,
im glad and excited to see that you begin to notice signs of problem i mentioned before that
'someone will sooner or later point at this'.

@WildcardSearch
Copy link
Owner Author

Even tho this is not this nor other addons fault, because the true cause come from core design

How is the core design causing problems with this add-on. Please don't make statements without qualifying them because it leaves me confused.

Cheers

@avril-gh
Copy link
Contributor

avril-gh commented Feb 4, 2013

Im not confusing you.
Even tho my speech may be enigmatic at this moment, you will understand it later.
Im preserving your concentration and increasing your perception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WildcardSearch WildcardSearch

Labels
bug enhancement fixed
Projects
None yet
Milestone
1.4
Development

No branches or pull requests
2 participants
@WildcardSearch @avril-gh