Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't Uninstall Add-on Modules Permanently #36

Closed
WildcardSearch opened this issue Feb 3, 2013 · 1 comment
Closed

Can't Uninstall Add-on Modules Permanently #36

WildcardSearch opened this issue Feb 3, 2013 · 1 comment
Assignees
@WildcardSearch
Labels
bug fixed
Milestone
1.4

Comments

@WildcardSearch
Copy link
Owner

The upgrade script in Sidebox_addon::load() isn't checking to see if the addon was already installed prior to versioning and is being re-installed regardless of admins wishes.

Need to add check and only upgrade if the module is currently installed.
@ghost ghost assigned WildcardSearch Feb 3, 2013
WildcardSearch pushed a commit that referenced this issue Feb 3, 2013
Beta Update #4
b648407 
Issue #35 fixed by reworking Search box templates to use `$mybb` object (saving unnecessary queries) and added options to the search box.

Issue #36 fixed by checking that an add-on module is installed before upgrading (casued uninstalled modules to instantly be re-installed on load (any load of `Sidebox_handler` object)

Issue #29 addressed again to further simplify moduls as much as possible for the developer and end-user while maintaining performace and functionality.

Thanks to @avril-gh for patience and for speaking up!
@WildcardSearch
Copy link
Owner Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WildcardSearch WildcardSearch

Labels
bug fixed
Projects
None yet
Milestone
1.4
Development

No branches or pull requests
1 participant
@WildcardSearch