Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random quote linebreak #62

Closed
Destroy666x opened this issue Feb 20, 2013 · 4 comments
Closed

Random quote linebreak #62

Destroy666x opened this issue Feb 20, 2013 · 4 comments
Assignees

Comments

@Destroy666x
Copy link
Contributor

There is a possibility that the query will get a post like:

AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAa

It stretches the whole sidebar then.
What about checking for xx amount of chars (depending on width) and breaking the line if a word is longer than that?

@ghost ghost assigned WildcardSearch Feb 20, 2013
@WildcardSearch
Copy link
Owner

Yes that seems to happen from time to time. As I am getting the post as a string, I am not certain the best way of fixing this (short of some kind of word-by-word break-down) . . .

Thanks for the report. I will look into it.

@Destroy666x
Copy link
Contributor Author

While trying to do function with explode and so on an easier non-PHP solution came to my mind.

In adv_sidebox_classes:
Change:

<table style="word-wrap:break-word;" border="0" cellspacing="{$theme[\'borderwidth\']}" cellpadding="{$theme[\'tablespace\']}" class="tborder ' . $this->box_type . '_main_' . $this->id . '">

To:

<table style="table-layout:fixed; word-wrap:break-word;" border="0" cellspacing="{$theme[\'borderwidth\']}" cellpadding="{$theme[\'tablespace\']}" class="tborder ' . $this->box_type . '_main_' . $this->id . '">

It will keep the sidebar always the width specified in settings, also cells in it if they have width/height attribute. Without fixed table layout word-wrap is kinda useless there.

@WildcardSearch
Copy link
Owner

Okay I will give that a try.

Thanks so much for your help 😄

WildcardSearch pushed a commit that referenced this issue Feb 22, 2013
New drag and drop interface. Simplified ASB ACP page structure. Combined Custom Box menus to one tab.

Issue #47 Another stab at reducing BB code slippage

Issue #53 Replaced odd workaround code for Random Quotes module with Admin setting

Issue #56 Several enhancements suggested by Destroy666

Issue #60 Destroy666 spotted an unnecessary query in the UCP code /fxt

Issue #62 Destroy66 suggested a CSS improvement to prevent long (no space) words from increasing column width

Issue #63 Avatar size reduced in Staff Online Box (thanks sarge)
@WildcardSearch
Copy link
Owner

Done thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants