columns not working correctly

[jlato89]

Just tried the updated version and it doesn't seem to be splitting the columns at all. It looks as though there's only one column with the leftside/middle/rightside going from top to bottom.

Currently using this theme -- http://mods.mybb.com/view/blackevo4-2

On a side note,
Maybe add an option to specify custom variables to manually add/edit themes to work? would prob make it universal to themes.

[WildcardSearch]

I replied on MyBB Community forums. I tried that theme and was not able to reproduce the bug.

Is this on a live forum or a localhost installation?

[jlato89]

Live forum. may i ask how your plugin works? does it overwrite the current theme with its own template or does it change the wway the template is shown. im just trying to figure out how that wworks to better help you.

[WildcardSearch]

Is it possible to PM me a link so that I can take a look at the HTML output from the page in question?

And to answer your question I am editing the template cache in real time so that no templates get edited. The plugin wraps the entire contents of each page (below {$header} and above {$footer}) in a three column table and insert the boxes into the appropriate column.

Now one moar question :D

Are you using 'Rand Quote' sidebox? <-- it is experimental and sometimes clips HTML tags in half and messes with the screen. If so hold off on using this experimental sidebox on a live forum.

[jlato89]

ur last question no, heres the link to my site http://trusted-medics-ofthe-wasteland.com/
it defaults to the portal page.

[WildcardSearch]

I think I found your problems:

Error Line 120, Column 8: end tag for "table" which is not finished

Error Line 234, Column 8: end tag for "table" which is not finished

Error Line 293, Column 8: end tag for "table" which is not finished

Error Line 354, Column 8: end tag for "table" which is not finished

Error Line 523, Column 8: end tag for "table" which is not finished

These invalid <table> tags are being ignored by your browser and that is causing the display problems.

[jlato89]

in portal or some other template?

[WildcardSearch]

index.php

I just ran the validator on them and copied and paste the relevant errors.

[jlato89]

il check it out in a bit.. thx

[WildcardSearch]

No problem. Good luck I will close this issue but if you have problems or discover that is IS an issue with the plugin then we can just reopen it.

Cheers

[jlato89]

i do have a question, your vanilla install of the theme had no issues right?

[WildcardSearch]

No. @avril-gh has been finding a few invalid blocks of HTML and we have committed some fixes, but as for display issues I haven't seen any.

[jlato89]

ok. also i just deactivated all of my plugins and still had the issue so im guessing its either the template or the plugin. I didnt modify the templates that much so im a bit confused as to where these issues are coming from. however im going to be going through all of these templates and make sure the table vars are being closed.

[jlato89]

After some testing iv found that one of the "Welcome" blocks caused the issues. I have duplicates of the following -
Search, Private Messages, & Welcome.
Only one of the welcome "blocks" carries the issue with it. IDK whats causing the duplicate blocks above but may have been part of the issue.

also it looks like latest threads add a few extra space above the middle part

[WildcardSearch]

Okay I know what the problem is maybe.

In version 1.3.1 I discovered that some of my template variable names conflicted with global templates available elsewhere. Because of this some modules were renamed.

Look in your forums's inc/plugins/adv_sidebox/modules directory and see if you have a folder names 'pms' or 'search' or 'welcome' and also check to see if you have 'private_message' and 'search_box' and 'welcome_box' . . . having both boxes installed causes issues. Just delete the first three folders I named (the ones without _box on the end) and this should solve your problem.

If you don't have those extra folders let me know.

[jlato89]

i went ahead and deleted -> 'private_message' and 'search_box' and 'welcome_box' and it seems to have fixed the table issue. also idk if you caught my edit on the last reply but the latest threads is adding a big gap in the middle. like its adding space in the middle then showing the middle content. this seems to happen when using the latest threads block.

[WildcardSearch]

You deleted the wrong boxes. Those are the new ones.

As for your other comment I don't know what you mean.

[jlato89]

oh oops. il fix. also if you go here- http://trusted-medics-ofthe-wasteland.com/ you will see what i mean.

the middle portion follows the latest threads. like if i add it further down the bottom of the page(couple of blocks above it) the middle portion will go even further down.

[WildcardSearch]

The answer lies in fixing errors in your custom box:

<tr>
    <td class="trow1">      <tr>
        <td class="trow1"><iframe src="http://cache.www.gametracker.com/components/html0/?host=199.168.142.58:9987&bgColor=333333&fontColor=CCCCCC&titleBgColor=222222&titleColor=FF9900&borderColor=555555&linkColor=FFCC00&borderLinkColor=222222&showMap=0&currentPlayersHeight=200&showCurrPlayers=1&showTopPlayers=0&showBlogs=0&width=200" frameborder="0" scrolling="no" width="200" height="388"></iframe></td>
    </tr>
    </td></tr>

is incorrect. That HTML leaves tags open and results in display errors.

Of course the box content will look a little different, but your table layout inside the textarea should look something like this:

    <tr>
        <td class="trow1"><iframe src="http://cache.www.gametracker.com/components/html0/?host=199.168.142.58:9987&bgColor=333333&fontColor=CCCCCC&titleBgColor=222222&titleColor=FF9900&borderColor=555555&linkColor=FFCC00&borderLinkColor=222222&showMap=0&currentPlayersHeight=200&showCurrPlayers=1&showTopPlayers=0&showBlogs=0&width=200" frameborder="0" scrolling="no" width="200" height="388"></iframe></td>
    </tr>

[jlato89]

Ah i didint notice that mistake. thanks for the catch. however that didnt fix anything. the issue with the middle part is connected to the latest threads. if i remove it then the middle portion goes back to normal.
Iv removed the custom box to eliminate that var.

[WildcardSearch]

Well it will wind up being some error with your template or an open tag.

[jlato89]

it must be. but its only linked to the latest threads block. and i havnt edited that block so idk. I guess il just disable the block till the next update as i cant find outn why its misaligned.

UPDATE- Found out that the latest threads block was the issue because it was to long height wise. After going into the pref and changing the "Number of latest discussions to show " to 8 it solved my issue. The default 10 value made it overlap and cause the gap in the middle portion of the site. call it a fix or a work around but hopefully it can help someone else who has the same issue.

[WildcardSearch]

Actually that brings up an issue I hadn't thought of. The Latest Threads sidebox really should create its own setting instead of relying on the portal setting.

Would you mind creating an issue for that so that I remember who brought it to my attention?

'Add Thread Count Setting To Latest Threads Sidebox' or something 😄

[jlato89]

Sure thing. il addd it right now. you can prob close this issue as well as it pretty much resolved.