Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-14013] "javax.servlet.error.message" also should be transformed to "jakarta.servlet.error.message" in jakarta-direct.properties #85

Merged
merged 1 commit into from Oct 30, 2020

Conversation

scottmarlow
Copy link
Collaborator

https://issues.redhat.com/browse/WFLY-14013

@jfdenise where are the latest EE-9 galleon-plugins kept these days? Also, which branch should I build locally to try a Batavia change?

Thanks,
Scott

Copy link
Collaborator

@ropalka ropalka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In JIRA you mention also javax.servlet.error.exception_type, we should add it

@jfdenise
Copy link
Contributor

@scottmarlow
Copy link
Collaborator Author

In JIRA you mention also javax.servlet.error.exception_type, we should add it

Thanks Richard,I will add an entry for that, whether javax.servlet.error.exception=>javax.servlet.error.exception covers javax.servlet.error.exception_type or not, it will be more clear to have an entry for javax.servlet.error.exception_type

… to "jakarta.servlet.error.message" in jakarta-direct.properties
@scottmarlow
Copy link
Collaborator Author

@scottmarlow
Copy link
Collaborator Author

@ropalka are there further changes needed? If not, I think this is ready to be merged. Thanks!

Copy link
Collaborator

@ropalka ropalka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK Scott. Sorry for delay.

@ropalka ropalka merged commit eb9ec43 into wildfly-extras:master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants