Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn user if any conflicts detected #88

Closed
spyrkob opened this issue Jul 1, 2022 · 2 comments · Fixed by #276
Closed

Warn user if any conflicts detected #88

spyrkob opened this issue Jul 1, 2022 · 2 comments · Fixed by #276
Labels
must-have
Milestone
GA

Comments

@spyrkob
Copy link
Collaborator

spyrkob commented Jul 1, 2022

Probably will need to modify Galleon for this.

Example: if user modified file 'standalone.xml' and the update modified 'standalone.xml', before the old server is replaced with updated one, we should prompt user whether he's happy to continue.
@spyrkob spyrkob added the question Further information is requested label Jul 1, 2022
@spyrkob spyrkob added this to the GA milestone Jul 1, 2022
@spyrkob spyrkob removed the question Further information is requested label Jul 13, 2022
@spyrkob
Copy link
Collaborator Author

spyrkob commented Jul 13, 2022

Galleon issue: https://issues.redhat.com/browse/GAL-338

@jfdenise
Copy link
Collaborator

With the redesign of the update (WIP branch: https://github.com/jfdenise/prospero/tree/future), such logic should be implemented directly in Prospero.

This was referenced Dec 16, 2022
Closed
Merged
@spyrkob spyrkob mentioned this issue Feb 16, 2023
Merged
spyrkob added a commit to spyrkob/prospero that referenced this issue Feb 16, 2023
@spyrkob
[wildfly-extras#88] Print conflicts and changes in update and revert …
7555986 
…operations
spyrkob added a commit to spyrkob/prospero that referenced this issue Feb 16, 2023
@spyrkob
[wildfly-extras#88] Print conflicts and changes in update and revert …
d434890 
…operations
spyrkob added a commit that referenced this issue Feb 17, 2023
@spyrkob
Merge pull request #276 from spyrkob/warn_conflicts
25c66b6 
[#88] Print conflicts and changes in update and revert  operations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
must-have
Projects
None yet
Milestone
GA
Development

Successfully merging a pull request may close this issue.

[#88] Print conflicts and changes in update and revert operations spyrkob/prospero
2 participants
@spyrkob @jfdenise