Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify module checker to work with feature packs #1638

Closed
jamesnetherton opened this issue Feb 21, 2017 · 2 comments
Closed

Modify module checker to work with feature packs #1638

jamesnetherton opened this issue Feb 21, 2017 · 2 comments
Assignees
@jamesnetherton
Labels
task
Milestone
4.6.0

Comments

@jamesnetherton
Copy link
Collaborator

Currently the module checker only works with module.xml files that contain resource-root elements. Feature pack generated modules contain artifact elements with Maven GA coordinates.
@jamesnetherton jamesnetherton added this to the 4.6.0 milestone Feb 21, 2017
@jamesnetherton jamesnetherton self-assigned this Feb 21, 2017
@tdiesler tdiesler mentioned this issue Feb 21, 2017
Closed
jamesnetherton added a commit to jamesnetherton/wildfly-camel that referenced this issue Feb 22, 2017
@jamesnetherton
[resolves wildfly-extras#1638] Modify module checker to work with fea…
fdc0cc0 
…ture packs
jamesnetherton added a commit to jamesnetherton/wildfly-camel that referenced this issue Feb 22, 2017
@jamesnetherton
[resolves wildfly-extras#1638] Modify module checker to work with fea…
9bc4b09 
…ture packs
jamesnetherton added a commit to jamesnetherton/wildfly-camel that referenced this issue Feb 22, 2017
@jamesnetherton
[resolves wildfly-extras#1638] Modify module checker to work with fea…
5c9abd7 
…ture packs
@jamesnetherton
Copy link
Collaborator Author

Mods fail on Windows, urgh!.....

ERROR - Discovered 0 resources in layer 'base' and 512 resources in layer 'fuse'

Wondering if we should hook the Windows build into the PR process so that we get early warnings when things break.

@jamesnetherton
Copy link
Collaborator Author

Turns out this script has never worked properly on Windows, so it's kinda fortunate that I added some additional validation to trap this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesnetherton jamesnetherton

Labels
task
Projects
None yet
Milestone
4.6.0
Development

No branches or pull requests
1 participant
@jamesnetherton