Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on Stream.version #119

Closed
gaol opened this issue Nov 21, 2022 · 3 comments · Fixed by #133
Closed

Clarification on Stream.version #119

gaol opened this issue Nov 21, 2022 · 3 comments · Fixed by #133

Comments

@gaol
Copy link

gaol commented Nov 21, 2022

In the javadoc of Stream.version, it says that the version can be a list of comma-separated versions:

* This must be either a single version (e.g. "1.0.0.Final") or a list of comma-separated versions

but in the json schame, it says that: This must be either a single version.

"description": "Version of the stream. This must be either a single version. Only one of version, versionPattern must be set.",

We need to keep the version requirement consistent in the 2 places above.

@moulalis
Copy link

@gaol Who is verifying this? what it should be? either single version or both?

@gaol
Copy link
Author

gaol commented Jan 17, 2023

@moulalis , maybe @jmesnil or @spyrkob can comment on this

@spyrkob
Copy link
Contributor

spyrkob commented Jan 17, 2023

Thanks @gaol that should be a single version only

spyrkob added a commit to spyrkob/wildfly-channel that referenced this issue Jan 17, 2023
spyrkob added a commit to spyrkob/wildfly-channel that referenced this issue Jan 17, 2023
jfdenise added a commit that referenced this issue Jan 17, 2023
[#119] Correct Stream.version javadoc and schema description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants