Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootable classifier should be configurable #270

Closed
mareknovotny opened this issue Sep 9, 2021 · 10 comments · Fixed by #271
Closed

bootable classifier should be configurable #270

mareknovotny opened this issue Sep 9, 2021 · 10 comments · Fixed by #271

Comments

@mareknovotny
Copy link

mareknovotny commented Sep 9, 2021

i tried to change the default bootable jar suffix with outputFileName in wildfly-jar-maven-plugin see this mareknovotny@3dd49ad. As it is bound to package goal all works fine. The jar is generated correctly, but if i do mvn clean install the installed artifact is actually default bootable jar not the one with defined file name in outputFileName.
How to propagate that outputFileName into install goal?

[INFO] --- maven-install-plugin:2.4:install (default-install) @ jsf-ejb-jpa ---
[INFO] Installing /home/mnovotny/projects/git/wildfly-jar-maven-plugin/examples/jsf-ejb-jpa/target/jsf-ejb-jpa.war to /home/mnovotny/.m2/repository/org/wildfly/plugins/jsf-ejb-jpa/4.0.4.Final-SNAPSHOT/jsf-ejb-jpa-4.0.4.Final-SNAPSHOT.war
[INFO] Installing /home/mnovotny/projects/git/wildfly-jar-maven-plugin/examples/jsf-ejb-jpa/pom.xml to /home/mnovotny/.m2/repository/org/wildfly/plugins/jsf-ejb-jpa/4.0.4.Final-SNAPSHOT/jsf-ejb-jpa-4.0.4.Final-SNAPSHOT.pom
[INFO] Installing /home/mnovotny/projects/git/wildfly-jar-maven-plugin/examples/jsf-ejb-jpa/target/jsf-ejb-jpa-standalone.jar to /home/mnovotny/.m2/repository/org/wildfly/plugins/jsf-ejb-jpa/4.0.4.Final-SNAPSHOT/jsf-ejb-jpa-4.0.4.Final-SNAPSHOT-bootable.jar
@jfdenise
Copy link
Collaborator

jfdenise commented Sep 9, 2021

@mareknovotny , we are attaching the bootable jar file with the classifier "bootable". The name of the installed artifact follows the Maven GroupId, ArtifactId, Version, Classifier, Type naming.
To change the name of the installed artifact, you would need to change the artifactId of your project to have pom and artifact in sync.

@mareknovotny
Copy link
Author

Do you have an example of that?
@Rikkola tries to override classifier and we thought that outputFileName should do that or plugin should apply that. Concrete example is at kiegroup/kie-wb-distributions#1114 and it is part of already existing war artifact module.
So your recommendation is to create new module just for bootable jar ?

@jfdenise
Copy link
Collaborator

jfdenise commented Sep 9, 2021

@mareknovotny , if you install any Bootable JAR example, you will get the artifactid-version-bootable.jar being installed. As in your pasted example: jsf-ejb-jpa-4.0.4.Final-SNAPSHOT-bootable.jar
'bootable' is the classifier we are using.
From the PR you linked it seems that you need this classfier to be configurable. You would like to set it to "standalone". Right?

@mareknovotny
Copy link
Author

mareknovotny commented Sep 9, 2021

yes, that is true. We need that classifier to be standalone instead of bootable.

@jfdenise
Copy link
Collaborator

jfdenise commented Sep 9, 2021

Which version of the bootable JAR are you currently using? I think it makes sense to add this ability.

@Rikkola
Copy link

Rikkola commented Sep 9, 2021

Hi, we are on 4.0.3.Final

@jfdenise
Copy link
Collaborator

jfdenise commented Sep 9, 2021

You want to keep the 4.x or you can upgrade to 5.x?

@mareknovotny
Copy link
Author

we would like to keep in 4.x for now if possible, as we do try to use that version with EAP XP

@jfdenise
Copy link
Collaborator

jfdenise commented Sep 9, 2021

Ok, I am going to release a 4.1.0.Final

@jfdenise jfdenise changed the title outputFileName is not propagated into maven install phase? bootable classifier should be configurable Sep 9, 2021
jfdenise added a commit to jfdenise/wildfly-jar-maven-plugin that referenced this issue Sep 9, 2021
jfdenise added a commit to jfdenise/wildfly-jar-maven-plugin that referenced this issue Sep 9, 2021
@jfdenise
Copy link
Collaborator

jfdenise added a commit that referenced this issue Sep 10, 2021
Fix for issue #270, bootable classifier should be configurable
jfdenise added a commit that referenced this issue Sep 10, 2021
[4.x] Fix for issue #270, bootable classifier should be configurable
@jfdenise jfdenise closed this as completed Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants