WFCORE-2672: fix jdbc-realm validation #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pedroigor Could you please take a look at this one? Also to be merged we will also need a link to the corresponding JBEAP issue within this PR. |
pedroigor
approved these changes
May 11, 2017
|
This is ok. I had the same question @michpetrov did re: only checking the first principal query, but that's a separate thing from what's being fixed here, so I'm not going to express an opinion on whether that needs to be fixed in this PR. This validation logic could be done in an impl of finishModelStage instead of validateUpdatedModel, and that would let you check the attributeName param and only validate if PRINCIPAL_QUERY is the attribute, but that's not required. |
|
Sorry; I hit the close button by mistake when posting my last comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: WFCORE-2672
JBEAP issue: JBEAP-10321
@darranl I'm wondering what is being validated here, as currently (and still after my change) the
resolveKeyMapperschecks only the first principal query and not the others.