Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFCORE-2512] Make the module attribute required on all custom component definitions. #58

Merged
merged 1 commit into from Mar 10, 2017
Merged

[WFCORE-2512] Make the module attribute required on all custom component definitions. #58

merged 1 commit into from Mar 10, 2017

Conversation

darranl
Copy link

@darranl darranl commented Mar 9, 2017 •
edited by kabir

kabir
kabir reviewed Mar 9, 2017
View reviewed changes
elytron/src/main/java/org/wildfly/extension/elytron/CustomComponentDefinition.java
@@ -61,6 +63,10 @@
*/
class CustomComponentDefinition<T> extends SimpleResourceDefinition {

static final SimpleAttributeDefinition MODULE = new SimpleAttributeDefinitionBuilder(ClassLoadingAttributeDefinitions.MODULE)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be used anywhere?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used on line 78

@darranl darranl merged commit 770074c into wildfly-security-incubator:ladybird Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kabir kabir kabir left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@darranl @kabir