[ELY-1734] Clean up the 'wildfly-elytron-asn1' module as it currently contains public and private API #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjuma
reviewed
Feb 5, 2019
| * @author <a href="mailto:fjuma@redhat.com">Farah Juma</a> | ||
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
The util package should just be eliminated now that its two classes are being moved one level up
|
|
justinmcook
force-pushed
the
ELY-1734-Clean-up-wildfly-elytron-asn1
branch
2 times, most recently
from
1c6bebb
to
83c2f9e
Compare
fjuma
reviewed
Feb 5, 2019
| @@ -16,7 +16,7 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| package org.wildfly.security.asn1._private; | |||
| package org.wildfly.security.asn1; | |||
There was a problem hiding this comment.
This class needs to be made package private
… contains public and private API
justinmcook
force-pushed
the
ELY-1734-Clean-up-wildfly-elytron-asn1
branch
from
83c2f9e
to
9b5347b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.jboss.org/browse/ELY-1734