[WFLY-7254] pattern-filter disappears if predefined-filter is used for configurable-sasl-server-factory in Elytron subsystem #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darranl
requested changes
Oct 11, 2016
| if (current.hasDefined(ElytronDescriptionConstants.PREDEFINED_FILTER) | ||
| && current.hasDefined(ElytronDescriptionConstants.PATTERN_FILTER)) { | ||
| throw ROOT_LOGGER.invalidDefinition(ElytronDescriptionConstants.FILTERS); | ||
| } |
There was a problem hiding this comment.
Is there any way we can get this validation to happen earlier?
This method is only executed during Stage.RUNTIME when really we should be able to validate this during the model stage?
Don't spend too much time on it if it is very complex as we need to simplify this resource anyway.
There was a problem hiding this comment.
Moved the validation to "Filters" attribute definition.
configurable-sasl-server-factory in Elytron subsystem
darranl
approved these changes
Oct 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elytron Subsystem: https://issues.jboss.org/browse/WFLY-7254