Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ELYWEB-214] Upgrade Junit to 4.11 -> 4.13.2 #242

Open
wants to merge 1 commit into
base: 4.x
Choose a base branch
from
Open

[ELYWEB-214] Upgrade Junit to 4.11 -> 4.13.2 #242

wants to merge 1 commit into from

Conversation

VAIBHAVCES
Copy link

@VAIBHAVCES VAIBHAVCES commented Oct 13, 2023 •
edited

[ELYWEB-214] Upgrade Junit to 4.11 -> 4.13.2
Screenshot 2023-10-13 at 11 40 45 PM

@VAIBHAVCES VAIBHAVCES mentioned this pull request Oct 13, 2023
Closed
PrarthonaPaul
PrarthonaPaul approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@PrarthonaPaul PrarthonaPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

fjuma
fjuma approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @VAIBHAVCES!

@fjuma
Copy link
Contributor

fjuma commented Oct 31, 2023

@Skyllarr Please review and merge.

@PrarthonaPaul
Copy link
Contributor

This PR can be closed since junit is already upgraded to 4.13.2 here: https://github.com/wildfly-security/elytron-web/blob/4.x/pom.xml#L58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjuma fjuma fjuma approved these changes

@PrarthonaPaul PrarthonaPaul PrarthonaPaul approved these changes

@Skyllarr Skyllarr Awaiting requested review from Skyllarr Skyllarr is a code owner

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@VAIBHAVCES @fjuma @PrarthonaPaul