ELY-5 bis #10
Closed
ELY-5 bis #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 11, 2014
| @@ -18,6 +18,9 @@ | |||
|
|
|||
| package org.wildfly.security.password.impl; | |||
|
|
|||
| import static org.wildfly.security.password.interfaces.UnixSHACryptPassword.*; | |||
There was a problem hiding this comment.
I hate any form of wildcard import ;-) But I know others are more relaxed about it.
There was a problem hiding this comment.
Yeah I think static * is okay, and the reason is that all the definitions that would be imported are always found within one source file. In addition, the static members of interfaces tend to be more limited than those of classes.
|
Merged |
fjuma
referenced
this pull request
in justinmcook/wildfly-elytron
Jun 8, 2018
…ificate generation instead of using pre-generated CAs and certs
darranl
added a commit
to darranl-archive/2020-wildfly-elytron
that referenced
this pull request
Dec 12, 2018
[ELY-1711] Create new 'wildfly-elytron-audit' module
darranl
added a commit
to darranl-archive/2020-wildfly-elytron
that referenced
this pull request
Jan 7, 2019
Skyllarr
pushed a commit
to Skyllarr/wildfly-elytron
that referenced
this pull request
Sep 21, 2021
Update numbering in the jetty-standalone README file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorporates a slightly cleaned up version of pull #5 as well as a refactor to move the password string parsing facilities out into a separate utilities class, unifying all parsing/generating of crypt strings.