[ELY-1586] Update test suite to use certificate generation utilities #1151
Conversation
|
Can one of the admins verify this patch? |
|
This is OK to test. |
|
|
||
| @Override | ||
| public Statement apply(Statement current, Description description) { | ||
| return new Statement() { | ||
|
|
||
| @Override | ||
| public void evaluate() throws Throwable { | ||
| try { | ||
| setUp(); | ||
| } catch (Exception e) {} |
There was a problem hiding this comment.
If setUp() throws an exception for some reason, the empty catch block here will prevent it from being reported. Since evaluate() is already declared as throwing Throwable, the try/catch block could just be removed.
| if (trustFile.exists() == false) { | ||
| setUp(); | ||
| } | ||
| } catch (Exception e) {} |
There was a problem hiding this comment.
The same thing would happen with this empty catch block as well. Since the outer try/catch block already catches Exception, this inner try/catch block could just be removed.
| @@ -1,72 +0,0 @@ | |||
| Certificate: | |||
There was a problem hiding this comment.
I think the files for 02.pem to 06.pem should also be removed.
There was a problem hiding this comment.
I think src/test/resources/client.keystore should also be removed.
There was a problem hiding this comment.
Removed the extra files, except src/test/resources/client.keystore which is needed still for the unmodified PKCS10CertificateSigningRequestTest
…ificate generation instead of using pre-generated CAs and certs
|
qa ack not rfe |
|
This is ok to test |
|
@darranl can you say CI "ok to test"? :) (or maybe "add to whitelist" directly) |
https://issues.jboss.org/browse/ELY-1586