[ELY-1602] Temporarily add a Pem.generatePemX509Certificate() method that takes the ByteStringBuilder from Elytron as a parameter #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darranl
requested changes
Jun 13, 2018
…that takes the ByteStringBuilder from Elytron as a parameter
|
Good point, fixed. |
hkalina
approved these changes
Jun 13, 2018
|
qa ack - not rfe |
darranl
approved these changes
Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with Martin and Darran, this PR temporarily adds a
Pem.generatePemX509Certificate()method that takes theByteStringBuilderfrom Elytron as a parameter instead of the one from Common. This will prevent the need for modifyingorg.wildfly.extension.elytron.AdvancedModifiableKeyStoreDecoratorwhen building Core with the latest Elytron SNAPSHOT version. Sinceorg.wildfly.security.pem.Pemis private API, we can remove this new method later on to remove the duplication.https://issues.jboss.org/browse/ELY-1602