[ELY-1616] ldap-key-store requires attribute userPKCS12 on ldap entry… #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkalina
suggested changes
Jul 31, 2018
| if (attribute == null) { | ||
| log.tracef("Alias [%s] is not key entry", alias); | ||
| return false; | ||
| return engineIsCertificateEntry(alias); //todo jondruse if trusstore and is certificate then true |
There was a problem hiding this comment.
This does not look valid - if it is impossible to retrieve the key, why should isKeyEntry() return true?
Truststores using JKS file also contains certificates only, without key. I dont think TrustManager should require to claim any certificates has also a key...
There was a problem hiding this comment.
I'm sorry, that I commited a part of code which shouldn't been commited, I'll fix it
…, even if it should be mandatory
JiriOndrusek
force-pushed
the
ELY-1616-ldap-store
branch
from
9ccded4
to
ea58f1b
Compare
|
@hkalina It's fixed now. |
hkalina
approved these changes
Jul 31, 2018
fjuma
approved these changes
Jul 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…, even if it should be mandatory
Issue: https://issues.jboss.org/browse/ELY-1616